[MPlayer-dev-eng] [PATCH] vf_osd take two

[Diego Biurrun]

On Tue, Sep 06, 2005 at 04:44:01PM -0400, Jason Tackaberry wrote:
> 
> I hope this addresses most of the concerns.  The attached patch is
> diffed against current CVS.  Please let me know of any further changes
> that should be made -- merging it would be nice too. :)

Here is a preliminary review of the documentation.  Some general
remarks:

- Please start new sentences on a new line in the man page.
- Please use one and not two spaces to separate sentences.
- Please avoid trailing whitespace.

> --- main.orig/DOCS/tech/slave.txt	2005-09-05 23:07:18.000000000 -0400
> +++ main/DOCS/tech/slave.txt	2005-09-04 18:59:01.000000000 -0400
> @@ -218,6 +218,52 @@
>      as a float (e.g. 1.77778 for 16/9).
>      There might be problems with some video filters.
>  
> +panscan <-1.0 - 1.0> | <0.0 - 1.0> <absolute>
> +    Increase or decrease the pan-and-scan range by <value>, 1.0 is the maximum.
> +    Negative values decrease the pan-and-scan range.
> +    If <absolute> is != 0, then the pan-and scan range is interpreted as an
> +    absolute range.
> +
> [...]
> +
> +osdcmd <command>
> +    Manipulate the osd filter.  See DOCS/tech/vf_osd.txt for a detailed
> +    description of what commands are available.

Huh?  Looks like you messed this one up, there is a lot of stuff
duplicated now...


> --- main.orig/DOCS/man/en/mplayer.1	2005-09-05 23:07:16.000000000 -0400
> +++ main/DOCS/man/en/mplayer.1	2005-09-06 15:06:30.000000000 -0400
> @@ -5586,6 +5586,36 @@
>  .PD 1
>  .
>  .TP
> +.B osd=shmkey[:width:height]
> +Provides an OSD buffer to be accessed via shared memory which is
> +composited over the running video.  Pixels are specified in BGRA
> +format, and the the dimensions of the OSD image correspond to the width
> +and height argments if they are specified.  If the width and height

argUments

Diego