[MPlayer-dev-eng] [PATCH] vf_osd take two

Michael Niedermayer michaelni at gmx.at
Fri Sep 9 11:12:09 CEST 2005


Hi

On Wed, Sep 07, 2005 at 05:15:17PM -0400, Jason Tackaberry wrote:
> On Wed, 2005-09-07 at 23:00 +0200, Michael Niedermayer wrote:
> > > > > +            : "=r" (dst),
> > > > > +              "=r" (src),
> > > > > +              "=r" (osd),
> > > > > +              "=r" (alpha)
> > > > > +            : "m" (c) 
> > > > > +            : "%ecx", "memory");
> 
> > now "=r" (src) is a output so you may change it which you do but you expect
> > its initial value to be src which well is not guranteed
> 
> I see.  Then given that I change each of %1,%2,%3,%4 (I add $8 in the
> inner loop), I ought to change all of those to +r?  Is there a semantic

yes


> difference between "+r" (foo) and "=r" (foo) : "0" (foo)?  If it's

not as far as i know


> strictly a matter of style, is there a preference for code in mplayer?

not as far as i know

[...]

-- 
Michael




More information about the MPlayer-dev-eng mailing list