[MPlayer-dev-eng] Re: [PATCH] Automatic monitor aspect for X11

[Reimar Döffinger]

Hi,
On Fri, Apr 14, 2006 at 05:21:44PM +0200, Alban Bedel wrote:
> > Unless there are plans to implement it for anything besides X11, I'm
> > against the parts in aspect.[c|h].
> 
> That doesn't sound very logical to me. I'm pretty sure it should be
> possible to implement such thing for win32 and osx and cluttering
> such trival stuff under some #ifdef sound quiet lame to me.

Why #ifdef? Why not just put it in x11_common.c?
Moving it later wouldn't be a big deal, I just find it a bit weird to
define a variable in a file where it isn't used at all...

Greetings,
Reimar Döffinger