[MPlayer-dev-eng] Re: [PATCH] Automatic monitor aspect for X11

[Alban Bedel]

On Fri, 14 Apr 2006 22:37:47 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hi,
> On Fri, Apr 14, 2006 at 05:21:44PM +0200, Alban Bedel wrote:
> > > Unless there are plans to implement it for anything besides X11, I'm
> > > against the parts in aspect.[c|h].
> > 
> > That doesn't sound very logical to me. I'm pretty sure it should be
> > possible to implement such thing for win32 and osx and cluttering
> > such trival stuff under some #ifdef sound quiet lame to me.
> 
> Why #ifdef? Why not just put it in x11_common.c?

x11_common.c is only compiled if x11 is used, so if you do that you still
need to #ifdef the command line options.

> Moving it later wouldn't be a big deal, I just find it a bit weird to
> define a variable in a file where it isn't used at all...

Well it's directly related to another var defined there (monitor_aspect)
so that doesn't sound so weird to me. To be honest spreading related
stuff all over the place is not really what i would call a good thing.

	Albeu