[MPlayer-dev-eng] [PATCH 1/5] ao_alsa: remove mmap support

[Diego Biurrun]

On Fri, Feb 03, 2006 at 07:26:28PM +0100, Clemens Ladisch wrote:
> Reimar Döffinger wrote:
> > On Mon, Jan 30, 2006 at 09:14:32AM +0100, Clemens Ladisch wrote:
> > > This patch removes mmap support because it doesn't have any
> > > benefit.
> >
> > Well, at least normally our CVS policy forbids removing features...
> 
> Well, I didn't want to leave broken code it, and fixing it would
> have required to duplicate most of the other code.

I think we have to revisit that rule for good...

> > > +    if (ao_mmap)
> > > +      mp_msg(MSGT_AO,MSGL_WARN,"alsa-init: mmap option is
> > > obsolete and has no effect");
> >
> > IMHO, just remove the suboption instead.
> 
> I didn't want to break compatibility with old config files.

That's not necessarily a top priority.

> > > -static int play_normal(void* data, int len)
> > > +static int play(void* data, int len, int flags)
> >
> > These (and I think another one I somehow missed) are cosmetics,
> > please make sure that code you didn't change doesn't appear in the
> > diff. If the end result really looks too ugly it can still be fixed
> > afterwards.
> 
> OK, I could split it into two patches ...

That always helps.

Diego