[MPlayer-dev-eng] [PATCH 1/5] ao_alsa: remove mmap support

[Reimar Döffinger]

Hi,
On Fri, Feb 03, 2006 at 08:28:11PM +0100, Diego Biurrun wrote:
> On Fri, Feb 03, 2006 at 07:26:28PM +0100, Clemens Ladisch wrote:
> > Reimar Döffinger wrote:
> > > On Mon, Jan 30, 2006 at 09:14:32AM +0100, Clemens Ladisch wrote:
> > > > This patch removes mmap support because it doesn't have any
> > > > benefit.
> > >
> > > Well, at least normally our CVS policy forbids removing features...
> > 
> > Well, I didn't want to leave broken code it, and fixing it would
> > have required to duplicate most of the other code.
> 
> I think we have to revisit that rule for good...

The "normally" was supposed to indicate I won't insist on the rule in
this case *g*. I just wanted to make clear what normally is prefered.

> > > > +    if (ao_mmap)
> > > > +      mp_msg(MSGT_AO,MSGL_WARN,"alsa-init: mmap option is
> > > > obsolete and has no effect");
> > >
> > > IMHO, just remove the suboption instead.
> > 
> > I didn't want to break compatibility with old config files.
> 
> That's not necessarily a top priority.

No, and I personally much prefer breaking compatibility over silently
changing behaviour.

Greetings,
Reimar Döffinger