[MPlayer-dev-eng] [PATCH] Windows DLL support for OS X/Intel (cleaned version)

[Diego Biurrun]

On Wed, Oct 11, 2006 at 07:18:09PM -0400, Nicolas Plourde wrote:
> 
> On 25-Jul-06, at 6:26 PM, Valtteri Vuorikoski wrote:
> 
> >This is a somewhat saner version of the previous patch to enable  
> >DLL support on OS X/Intel. The caveat regarding DYLD_BIND_AT_LAUNCH  
> >still applies.
> >
> >A warning is now given if the user attempts to use DLL codecs  
> >without setting the environment variable. I'll fix the GUI to  
> >invoke mplayer proper with this variable set soon.
> >
> >mmap() of anonymous memory has been generalized into two new files,  
> >osdep/mmap_anon.c and .h. The new function mmap_anon() replaces the  
> >previous uses of open(/dev/zero)+mmap() in loader/. FILE_dommap()  
> >has been cleaned somewhat as a result. As far as I can see,  
> >semantics for existing code are unaffected. FILE_dommap() now  
> >honors the flags argument. Unfortunately I don't have easy access  
> >to suitable test machines.
> >
> >I have left in the change regarding loader_objfix.sh/stubs.s, since  
> >I think it's a bit silly to have two methods for two platforms to  
> >achieve the same result. loader_objfix.sh should be removed.  
> >stubs.s should be renamed to stubs.S and the Makefile changed  
> >accordingly for maximum canonicality (since stubs.[sS] is now  
> >preprocessed, though with the current Makefile there's no practical  
> >difference).
> 
> Any objection before I commit those patch? One is to fix compilation  
> on intel osx and the other one add support for win32 dll on intel osx.

> --- loader/Makefile	(revision 20168)
> +++ loader/Makefile	(working copy)
> @@ -36,9 +41,6 @@
>  
>  libloader.a:  $(LIB_OBJECTS) stubs.s
>  	$(CC) -c ./stubs.s -o stubs.o
> -ifeq ($(TARGET_OS),OpenBSD)
> -	./loader_objfix.sh
> -endif
>  	$(AR) -r libloader.a $(LIB_OBJECTS) stubs.o
>  	$(RANLIB) libloader.a

This hunk looks unrelated, although it's probably correct.  IIRC only
very old OpenBSD versions require this, so it should be safe to drop it.

Diego