[MPlayer-dev-eng] [PATCH] Windows DLL support for OS X/Intel (cleaned version)

[Reimar Döffinger]

Hello,
On Wed, Oct 11, 2006 at 07:18:09PM -0400, Nicolas Plourde wrote:
> Any objection before I commit those patch? One is to fix compilation  
> on intel osx and the other one add support for win32 dll on intel osx.

Yes, at least the loader patch should be split.
The mmap_anon part seems fine to me, but IMHO it should use
MAP_ANONYMOUS instead of MAP_ANON (and define MAP_ANONYMOUS as MAP_ANON
if only the later is available), and default to anonymous mmap for all
systems that provide it, since /dev/zero even currently causes problem
when e.g. /dev is mounted noexec or /dev/zero not writable (there is a
bugzilla entry about that).
And a .s can't use C macros, it must at least be renamed to .S.
Didn't have a real look at the mp3lib patch, but I do not like disabling
the MMX stuff, it just hides the problems.
Since there is again an active upstream it might be a good idea to
coordinate patches with them, too.

Greetings,
Reimar Döffinger