[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[Diego Biurrun]

On Wed, Aug 06, 2008 at 08:59:49AM -0400, compn wrote:
> On Wed, 6 Aug 2008 09:13:46 +0200, Diego Biurrun wrote:
> >On Tue, Aug 05, 2008 at 07:57:36PM -0400, compn wrote:
> >> On Tue, 5 Aug 2008 23:38:45 +0200, Diego Biurrun wrote:
> >> >On Sat, Aug 02, 2008 at 07:58:39PM +0200, Diego Biurrun wrote:
> >> >> Here is a patch to remove a redundant XShmGetEventBase declaration from
> >> >> libvo/vo_x11.c and libvo/vo_xvmc.c, which dates back to r2(!).  If this
> >> >> is really a problem, there should be a proper check in configure, not a
> >> >> hackish declaration duplicated over multiple files.
> >> >
> >> >Will apply on the weekend.
> >> 
> >> then you will be breaking rule 5 and 9 since iive has already
> >> rejected it for vo_xvmc.
> >> 
> >> rule 9 says "actively maintained" and iive reviews vo_xvmc patches so
> >> i believe its active.
> >
> >I don't remember a review, much less a timely one.  All of the XVMC
> >stuff has had known issues for many years, none of which were ever
> >addressed, even though there were promises to do so.  In my book, this
> >is incompatible with any interpretation of the term "actively
> >maintained".
> 
> are these bugs documented somewhere? a quick search on bugzilla returns 0.

Off the top of my head:

- crash with libmenu
- unfinished configure part
- duplicated xvmc_render.h header (exists in libavcodec as well)
- code duplication with vo_xv.c

Diego