[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[compn]

On Wed, 6 Aug 2008 21:06:53 +0200, Diego Biurrun wrote:
>On Wed, Aug 06, 2008 at 08:59:49AM -0400, compn wrote:
>> On Wed, 6 Aug 2008 09:13:46 +0200, Diego Biurrun wrote:
>> >On Tue, Aug 05, 2008 at 07:57:36PM -0400, compn wrote:
>> >> On Tue, 5 Aug 2008 23:38:45 +0200, Diego Biurrun wrote:
>> >> >On Sat, Aug 02, 2008 at 07:58:39PM +0200, Diego Biurrun wrote:
>> >> >> Here is a patch to remove a redundant XShmGetEventBase declaration from
>> >> >> libvo/vo_x11.c and libvo/vo_xvmc.c, which dates back to r2(!).  If this
>> >> >> is really a problem, there should be a proper check in configure, not a
>> >> >> hackish declaration duplicated over multiple files.
>> >> >
>> >> >Will apply on the weekend.
>> >> 
>> >> then you will be breaking rule 5 and 9 since iive has already
>> >> rejected it for vo_xvmc.
>> >> 
>> >> rule 9 says "actively maintained" and iive reviews vo_xvmc patches so
>> >> i believe its active.
>> >
>> >I don't remember a review, much less a timely one.  All of the XVMC
>> >stuff has had known issues for many years, none of which were ever
>> >addressed, even though there were promises to do so.  In my book, this
>> >is incompatible with any interpretation of the term "actively
>> >maintained".
>> 
>> are these bugs documented somewhere? a quick search on bugzilla returns 0.
>
>Off the top of my head:
>
>- crash with libmenu
iive posted a patch to stop the crash, it went ignored. where is libmenu maintainer? also he requested some help with vf stuff to get libmenu working with xvmc , but got no reply.
http://lists.mplayerhq.hu/pipermail/mplayer-users/2008-June/073275.html

>- unfinished configure part
what needs to be done exactly? there are multiple threads about configure and xvmc problems over the years, with fixes commited and patches ignored.

>- duplicated xvmc_render.h header (exists in libavcodec as well)
yep thats a duplicated header. will ffmpeg get it svn external or mplayer?
this older message might describe the current situation:
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2005-April/000283.html

>- code duplication with vo_xv.c
some of this was done?
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-March/050085.html
reimar was doing code duplication removal from xvmc and other vo's.


you could ask iive to test your patch and see if it breaks on his system.
instead of threatening to commit and ignoring his maintainership.
but i'm guessing you two are too busy fighting to talk to each other.

or just commit vo_x11 hunk, and ignore xvmc. i dont see any vo maintainers reject/approve vo_x11 patch either.

if you are trying to get rid of iive, you can find another xvmc maintainer
and get him to approve / reject patch. or vote in a project leader to override him. but you cannot commit without maintainer approval unless maintainer is absent for 2 weeks per svn rules.

-compn