[MPlayer-dev-eng] Direct3D OSD discussion

[Reimar Döffinger]

Hello,
On Mon, Dec 08, 2008 at 11:22:41AM +0100, Reimar Döffinger wrote:
> On Mon, Dec 08, 2008 at 09:14:59AM +0200, Georgi Petrov wrote:
> > I vote for inclusion now. If there are some indent / spacing issues,
> > I'll fix them after the patch is commited. We need the OSD.
> 
> Have you tested it?
> Also there is still almost the same buffer flow problem: the allocated
> texture may be smaller than the arguments to vo_draw_text, allowing for
> a buffer overflow.
> There are also minor issues like the expression to select
> non-power-of-two texture is extremely overcomplicated (e.g. !(a ^ b) is
> the same as a == b) and also wrong.
> I guess I can go over it myself and fix it when I got a bit of time.

This one should be better, but I could not test since wine is currently
broken on my system.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: d3d_osd.diff
Type: text/x-diff
Size: 16089 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081208/2cad183d/attachment.diff>