[MPlayer-dev-eng] Direct3D OSD discussion

[Jim Hauxwell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Reimar Döffinger wrote:
> Hello,
> On Mon, Dec 08, 2008 at 11:22:41AM +0100, Reimar Döffinger wrote:
>> On Mon, Dec 08, 2008 at 09:14:59AM +0200, Georgi Petrov wrote:
>>> I vote for inclusion now. If there are some indent / spacing issues,
>>> I'll fix them after the patch is commited. We need the OSD.
>> Have you tested it?
>> Also there is still almost the same buffer flow problem: the allocated
>> texture may be smaller than the arguments to vo_draw_text, allowing for
>> a buffer overflow.
>> There are also minor issues like the expression to select
>> non-power-of-two texture is extremely overcomplicated (e.g. !(a ^ b) is
>> the same as a == b) and also wrong.
>> I guess I can go over it myself and fix it when I got a bit of time.
> 
> This one should be better, but I could not test since wine is currently
> broken on my system.

I think it will suffer from the same problem that the original patch
has.  The texture will be stretched when the aspect is changed.

I'm also confused as to why the intrinsics were dropped, doesn't MPlayer
stipulate to compile on gcc only?  This is not an issue, just I would
like to know for future.

I would also like to know why there is a second draw in the
render_d3d_frame which only has enough vertices for a single triangle?
Are you trying to redraw the OSD?  If so, why?


Jim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk9B1IACgkQhrNWoHjgI1D9UACfZESj/flV4+3tfJ5dOH0nFgmB
3IkAoJWL5XFsAWKSnTs676caFmAwmESB
=Ed1s
-----END PGP SIGNATURE-----