[MPlayer-dev-eng] [PATCH] TV channel select from thumbnails - like XawTV

[Diego Biurrun]

On Sun, Dec 14, 2008 at 11:01:08AM +0100, Ötvös Attila wrote:
> 
> This patch add tvchsel video filter to MPlayer. This filter display thumbnails 
> from TV channels and supported select from those. (Like XawTV channel 
> selector.)
> 
> --- libmpcodecs/vf_tvchsel.c	(revision 0)
> +++ libmpcodecs/vf_tvchsel.c	(revision 0)
> @@ -0,0 +1,467 @@
> +inline static draw_alpha_f get_draw_alpha(uint32_t fmt) {

I have seen warnings somewhere when static was not the first keyword in
a function declaration.  Also, the opening brace should be on the next
line.

> --- libmpcodecs/vf_tvchsel.h	(revision 0)
> +++ libmpcodecs/vf_tvchsel.h	(revision 0)
> @@ -0,0 +1,36 @@
> +
> +#ifndef _VF_TVCHSEL_H_
> +#define _VF_TVCHSEL_H_

This is not a correct multiple inclusion guard.  Identifiers starting
with _ and uppercase are reserved for the system.

> +typedef struct vf_tvchsel_data_s {
> +    int on;     /* on/off flag */
> +    char* cmd;  /* command from tv_ch_sel first parameter */
> +    int dstart; /* first channel number of display thumbnail index */
> +    int dindex; /* current channel number of display thumbnail index */
> +    int sindex; /* select thumbnail index */
> +    int size;
> +    int time;
> +} vf_tvchsel_data_t;

_t is reserved POSIX namespace.  I know there are tons of places that
violate this in MPlayer, but there is no need to make things worse.

> --- stream/tv.h	(revision 28147)
> +++ stream/tv.h	(working copy)
> @@ -135,6 +136,15 @@
>  
> +typedef struct {
> +    int sindex;
> +    int dstart;
> +    int dindex;
> +    int size;
> +    int time;
> +    unsigned int timer;
> +} tv_chsel_t;

ditto

> --- DOCS/man/en/mplayer.1	(revision 28147)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -7167,6 +7167,44 @@
>  .
>  .TP
> +.B tvchsel[=size[:time]]
> +Allows TV channel select from thumbnails of the movie using slave mode
> +commands that can be bound to keypresses. Only use with mplayer.
> +See the slave mode documentation for details.

New sentences need to go on new lines in the manual page, same below.

Diego