[MPlayer-dev-eng] [PATCH] TV channel select from thumbnails - like XawTV

[Ötvös Attila]

Ezzel a dátummal: Sunday 14 December 2008 16:39:17 Diego Biurrun ezt írta:

Hi Diego Biurrun!
> I have seen warnings somewhere when static was not the first keyword in
> a function declaration.  Also, the opening brace should be on the next
> line.
>
> > --- libmpcodecs/vf_tvchsel.h	(revision 0)
> > +++ libmpcodecs/vf_tvchsel.h	(revision 0)
> > @@ -0,0 +1,36 @@
> > +
> > +#ifndef _VF_TVCHSEL_H_
> > +#define _VF_TVCHSEL_H_
>
> This is not a correct multiple inclusion guard.  Identifiers starting
> with _ and uppercase are reserved for the system.
>
> > +typedef struct vf_tvchsel_data_s {
> > +    int on;     /* on/off flag */
> > +    char* cmd;  /* command from tv_ch_sel first parameter */
> > +    int dstart; /* first channel number of display thumbnail index */
> > +    int dindex; /* current channel number of display thumbnail index */
> > +    int sindex; /* select thumbnail index */
> > +    int size;
> > +    int time;
> > +} vf_tvchsel_data_t;
>
> _t is reserved POSIX namespace.  I know there are tons of places that
> violate this in MPlayer, but there is no need to make things worse.
>
> > --- stream/tv.h	(revision 28147)
> > +++ stream/tv.h	(working copy)
> > @@ -135,6 +136,15 @@
> >
> > +typedef struct {
> > +    int sindex;
> > +    int dstart;
> > +    int dindex;
> > +    int size;
> > +    int time;
> > +    unsigned int timer;
> > +} tv_chsel_t;
>
> ditto
>
> > --- DOCS/man/en/mplayer.1	(revision 28147)
> > +++ DOCS/man/en/mplayer.1	(working copy)
> > @@ -7167,6 +7167,44 @@
> >  .
> >  .TP
> > +.B tvchsel[=size[:time]]
> > +Allows TV channel select from thumbnails of the movie using slave mode
> > +commands that can be bound to keypresses. Only use with mplayer.
> > +See the slave mode documentation for details.
>
> New sentences need to go on new lines in the manual page, same below.
>

I fixed.

Best regard.
Attila

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tvchsel-with-thumbnails.patch
Type: text/x-diff
Size: 28430 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20081214/01aae238/attachment.patch>