[MPlayer-dev-eng] [PATCH] libass: fix parsing of tracks extracted from containers

[Michael Niedermayer]

On Wed, Sep 10, 2008 at 06:14:47PM +0300, Uoti Urpala wrote:
> On Wed, 2008-09-10 at 16:30 +0200, Michael Niedermayer wrote:
> > On Wed, Sep 10, 2008 at 04:21:25PM +0300, Uoti Urpala wrote:
> > > On Wed, 2008-09-10 at 13:55 +0200, Michael Niedermayer wrote:
> > > > On Sun, Sep 07, 2008 at 06:23:11PM +0300, Uoti Urpala wrote:
> > > > > And even if you thought lavf users wouldn't need it, dropping the
> > > > > information when you remux mkv->mkv is bad unless you can be sure nobody
> > > > > anywhere has a use for it (which I think they do).
> > > > 
> > > > If readorder contains information that is usefull for a realistic case
> > > > Then we can try to find a way to export it.
> > > > Though that requires some realistic use case to be found first.
> > > 
> > > It allows easily comparing a .ass file that has gone through muxing to a
> > > multimedia container and back to one that hasn't. I've done that even
> > > though I haven't done much related to editing subtitles.
> > 
> > running both through sort before comparing allows that too.
> 
> Sorting also destroys the structure of the file.

it shouldnt be hard to sort one file so it maximally matches a reference
file.
I do not think this would be much harder than reordering by using some extra
matroska fields.

[...]
> 
> > [...]
> > > > vorbis packets also contain their duration.
> > > 
> > > They contain their number of samples. But you don't need that duration
> > > to time any display changes. Nothing special happens when the duration
> > 
> > You where suggesting to remove all timing information from the bitstream,
> > try to remove it from vorbis and mpeg2
> 
> Vorbis and mpeg2 have no comparable timing information in the bitstream.

i disagree


[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080910/40fd0b0f/attachment.pgp>