[MPlayer-dev-eng] [PATCH] VF Overlay

[Uoti Urpala]

On Mon, 2009-07-27 at 21:26 +0200, Benjamin Zores wrote:
> Attached is a shortened version of a video filter patch that was sent 
> ages ago by Jason Tackaberry.

Looks like it has some weird parts left from removed features. I wonder
which of those are bugs/redundant and which intended if weird
functionality.

+   * Fixed overlay update frame rate (of about 30 fps), irrespective of the
+     video's frame rate or pause state.

This is false. The only frame rate related part is some limiting which
seems pointless.

+NOTE: Currently, the only time the overlay update rate is independent of the
+video frame rate is when double buffering is disabled (with the -nodouble
+switch). When double buffering is enabled (which is the default behaviour
+in MPlayer) and the video is playing, the overlay can only be updated as fast
+as the video frame rate.

Does this have anything at all to do with the actual code in the posted
patch?


What is this filter really meant to do? For which use case? Wasn't the
use case for the original patch done differently, so why this version?