[MPlayer-dev-eng] [PATCH] VF Overlay

[Diego Biurrun]

On Thu, Jul 30, 2009 at 08:44:30PM +0200, Benjamin Zores wrote:
> Diego Biurrun wrote:
> >On Thu, Jul 30, 2009 at 07:45:18PM +0200, Benjamin Zores wrote:
> >>Diego Biurrun wrote:
> >>
> >>>>--- Makefile	(revision 29447)
> >>>>+++ Makefile	(working copy)
> >>>>@@ -521,6 +521,7 @@
> >>>>
> >>>>+SRCS_COMMON-$(NEED_SHMEM)    += libmpcodecs/vf_overlay.c
> >>>This cannot be the right condition.
> >>Because ?
> >>It requires SHM to work (the whole purpose of the filter btw).
> >
> >Then why NEED_SHM and not HAVE_SHM?
> 
> Because NEED_SHMEM is in config.mak for Makefile while HAVE_SHM is in 
> config.h for source. Other parts of Makefile also uses NEED_SHMEM.

The NEED_ directives are for broken OSes where we implement missing
functionality, see all the stuff below osdep/ that is compiled
conditional to NEED_XXX.

> >>--- DOCS/tech/vf_overlay.txt	(revision 0)
> >>+++ DOCS/tech/vf_overlay.txt	(revision 0)
> >>@@ -0,0 +1,225 @@
> >
> >K&R please.
> 
> For doc ??? What's that ?

Ummm, sorry, I meant the test program in TOOLS/, dunno how I got that
quote mixed up while cutting away the text...

Diego