[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Diego Biurrun]

On Sat, Aug 21, 2010 at 05:49:50PM +0200, Pásztor Szilárd wrote:
> Reimar Döffinger:
> > Well, not the problem I described, but if you want to disable frame
> > dropping, drop_frame would have to be set differently, not things changed
> > afterwards.
> > So at least the comment does not match the code.
> 
> Ok, here it is, although that doesn't change things one bit in reality...
> In a code so full of compiler warnings and hacks and generally lacking
> even the minimal indentation, such concerns don't seem to make much sense to
> me.

Which files are you referring to?

> Anyway, 2 more changes in dec_video.c to eliminate compiler warnings.

Separate issues in separate patches please.  Mixing issues in a single
patch is an automatic reason for rejection.

> --- mplayer-export-2010-08-21/mplayer.c	2010-08-16 12:33:33.000000000 +0200
> +++ mplayer-export-2010-08-21-h264-timing/mplayer.c	2010-08-21 17:45:59.705508881 +0200
> @@ -2402,27 +2408,50 @@ static double update_video(int *blit_fra
> +
> +    if (real)
> +    {
> +	sh_video->timer += frame_time;
> +	if (sh_video->pts != MP_NOPTS_VALUE)
> +	{
> +	    if (sh_video->last_pts != MP_NOPTS_VALUE)
> +	    {

Please respect the surrounding coding style and write 'if (...) {'.

Diego