[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Pásztor Szilárd]

Diego Biurrun:
> > In a code so full of compiler warnings and hacks and generally lacking
> > even the minimal indentation, such concerns don't seem to make much sense
> > to me.
> 
> Which files are you referring to?

Which not? Apparently, just by looking into e.g. mplayer.c or mencoder.c,
basically all rules of thumb are broken. Brace placement is inconsistent
(mixed K&R and linux style), indentation spaces are inconsistent (2, 4, 8),
concept of indentation levels is ignored (look at main() in mplayer.c...),
space usage is casual, and the list could go on...
And after a compile with 2> xxx, there are almost fewer files that are not in
the warning list than those that are in.
I can easily live with it, my aim is not to rant about code prettiness but
given these circumstances, repeated objections on this ground seem a little
freaky to me.

The "indent" utility could be very nicely parametrized to shape the code into
a coherent form.

> Separate issues in separate patches please.  Mixing issues in a single
> patch is an automatic reason for rejection.

Ok, corrections deleted.

> Please respect the surrounding coding style and write 'if (...) {'.

Did so, see attached.

       ------------------------------------------------------------------
       |  It's hard to make a comeback when you haven't been anywhere.  |
       ------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-h264-timing-20100821.diff
Type: application/octet-stream
Size: 10373 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100821/c7e73e31/attachment.obj>