[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Reimar Döffinger]

On Wed, Oct 06, 2010 at 10:11:53PM +0200, Michael Niedermayer wrote:
> On Fri, Aug 20, 2010 at 08:17:29AM +0200, Reimar Döffinger wrote:
> > On Thu, Aug 19, 2010 at 10:47:58PM -0700, Alexander Strange wrote:
> > > > Yes it is clearly a bug, as vital information gets lost. However, in
> > > > libavcodec/h264.c, if we return -1 instead of 0 (at "Wait for second
> > > > field"),
> > > > which may not be a pretty way of signalling this special case, it works.
> > > 
> > > I really don't want to see an error code returned for something not an error.
> > 
> > But it is an error, FFmpeg requires the data for a full frame for all decoders.
> > As such, if there is only a single field in a packet, the decoder should return
> > an error (preferably a special value meaning "well, I can handle this, but this
> > is insufficient data").
> 
> This is incorrect, the h264 decoder as well as others can work with a slice at
> a time if you set the correct flags.

Can work yes, but it is not really in sync with how the API is supposed to be
used (not to mention the case when those flags are not set).