[MPlayer-dev-eng] [PATCH] unified timing patch for H264

[Michael Niedermayer]

On Thu, Sep 02, 2010 at 10:01:39AM +0000, Carl Eugen Hoyos wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> 
> > > Do we still care about -demuxer lavf -nocorrect-pts?
> > > It is completely broken with your patch (and a PAFF stream).
> > 
> > On the other hand, I think it will make
> > -demuxer lavf -fps ...
> > work correctly I think?
> > Of course the problem is that this breaks mencoder
> > with any such stream which maybe isn't so great.
> 
> I don't see a difference in mencoders behaviour with or without the patch: In
> both cases. PAFF in MPEG as input works ok with -demuxer lavf, but not with the
> native demuxer.
> (Is it known that mencoder -oac lavc -of avi is completely broken meaning it
> produces avi's with seemingly funny audio timestamps?)
> 
> > I'm sure it was mentioned before, but could someone summarize
> > what it fixes and what it breaks, possibly linking samples
> > for each?
> 
> All PAFF samples in MPEG TS streams are fixed for the native demuxer (and
> nocorrect-ots which is the default) with this patch, -demuxer lavf
> -nocorrect-pts (which is not the default) is broken for all (?) MPEG TS streams
> containing PAFF with the patch.
> 
> The advantage of the native TS demuxer is that seeking works much better (from a
> users pov at least), sync after seek is fine and even with my ORF recordings
> that don't want to seek with -demuxer lavf (roundup issue 1963), seeking works
> fine with the native demuxer.

for seeking in mpeg with discontinuities (AVFMT_TS_DISCONT)
AVSEEK_FLAG_BYTE must be set

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101006/37f1fa05/attachment.pgp>