[MPlayer-dev-eng] [PATCH] SMPlayer's audio equalizer slave command patch

[Adrian Stutz]

On Fri, Oct 15, 2010 at 07:34, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> Remove the documentation from the .c file, duplicated documentation
> only means that sooner or later at least on will be wrong.

Ok. But all the documentation is duplicated between af.h and af.c.
Maybe it would be better to remove the documentation for public
functions in af.c all together.

> I don't think you should call reinit if af is NULL.
> I actually propose to write it like this:
> if (!af) {
>    mp_msg(...);
>    break;
> }
> handling of "exceptional" cases should clutter the code as little
> as possible and stand out as a special case IMO.

Ok. The sh_audio check is ok, though? Since it needs a block anyway...

Updated patches attached.

Greetings,
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_add_af_reinit_v2.diff
Type: application/octet-stream
Size: 1125 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101016/83c299a1/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_af_cmdline_command_v4.diff
Type: application/octet-stream
Size: 2203 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101016/83c299a1/attachment-0001.obj>