[MPlayer-dev-eng] [PATCH] SMPlayer's audio equalizer slave command patch

[Reimar Döffinger]

On Sat, Oct 16, 2010 at 07:17:07PM +0200, Adrian Stutz wrote:
> On Fri, Oct 15, 2010 at 07:34, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > Remove the documentation from the .c file, duplicated documentation
> > only means that sooner or later at least on will be wrong.
> 
> Ok. But all the documentation is duplicated between af.h and af.c.
> Maybe it would be better to remove the documentation for public
> functions in af.c all together.
> 
> > I don't think you should call reinit if af is NULL.
> > I actually propose to write it like this:
> > if (!af) {
> >    mp_msg(...);
> >    break;
> > }
> > handling of "exceptional" cases should clutter the code as little
> > as possible and stand out as a special case IMO.
> 
> Ok. The sh_audio check is ok, though? Since it needs a block anyway...
> 
> Updated patches attached.

Applied with some minor spelling/cosmetic fixes.
Thanks.