[MPlayer-dev-eng] [PATCH] win32 gui open disk for audio cd

[Ingo Brückl]

Reimar Döffinger wrote on Thu, 29 Dec 2011 16:11:29 +0100:

> On Wed, Dec 28, 2011 at 09:19:30PM +0100, Ingo Brückl wrote:
>> -#ifdef CONFIG_LIBCDIO
>> +#if defined(CONFIG_LIBCDIO) || defined(CONFIG_CDDA)

> Huh, what would be the point of this code when CONFIG_CDDA is set?
> Or the other way round, why would CONFIG_LIBCDIO and not CONFIG_CDDA be
> set?
> I think this should just check for CONFIG_CDDA.
> Except for the fact that CONFIG_CDDB might be enough, too.

Well, this was my question in the thread "Audio CD questions" on Dec, 15,
because I wasn't quite sure from the configure script:

  "There seem to be several libraries possible to enable audio CD playback
  (stream_cdda). I myself installed cdparanoia and get CONFIG_CDDA. In
  configure I find CONFIG_LIBCDIO (and CONFIG_CDDB?) as well. So, is
  #if defined(CDDA) || defined(LIBCDIO) what I should check?"

Your answer was: probably yes.

> Can't you just throw away all those ifdefs except for those in
> interface.c?
> I think it should still compile fine and react reasonably even when cdda
> support is missing.

Yeah, I think there are currently too much of them. It's a point on my list
to only use them were necessary. (At the moment I just follow the ifdef
coding style I find in the files.)

Ingo