[MPlayer-dev-eng] [PATCH] win32 gui open disk for audio cd

[Reimar Döffinger]

On Thu, Dec 29, 2011 at 04:51:24PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Thu, 29 Dec 2011 16:11:29 +0100:
> 
> > On Wed, Dec 28, 2011 at 09:19:30PM +0100, Ingo Brückl wrote:
> >> -#ifdef CONFIG_LIBCDIO
> >> +#if defined(CONFIG_LIBCDIO) || defined(CONFIG_CDDA)
> 
> > Huh, what would be the point of this code when CONFIG_CDDA is set?
> > Or the other way round, why would CONFIG_LIBCDIO and not CONFIG_CDDA be
> > set?
> > I think this should just check for CONFIG_CDDA.
> > Except for the fact that CONFIG_CDDB might be enough, too.
> 
> Well, this was my question in the thread "Audio CD questions" on Dec, 15,
> because I wasn't quite sure from the configure script:
> 
>   "There seem to be several libraries possible to enable audio CD playback
>   (stream_cdda). I myself installed cdparanoia and get CONFIG_CDDA. In
>   configure I find CONFIG_LIBCDIO (and CONFIG_CDDB?) as well. So, is
>   #if defined(CDDA) || defined(LIBCDIO) what I should check?"
> 
> Your answer was: probably yes.

Then I was wrong.
CONFIG_CDDA == CONFIG_LIBCDIO || CONFIG_CDPARANOIA (always, no way to
change that as far as I can tell besides manually hacking config.h).
CONFIG_CDDB == CONFIG_CDDA && CONFIG_NETWORKING (by default, but can be
forced both on and off, can probably be made to compile with CDDA off
- but we shouldn't care much about that case - but not with NETWORKING off).