[MPlayer-dev-eng] [PATCH] add checkmark for menuitem for Debug Console

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Aug 14 20:04:46 CEST 2012


On Tue, Aug 14, 2012 at 03:22:29PM +0200, Ingo Brückl wrote:
> Stephen Sheldon wrote on Fri, 10 Aug 2012 11:55:49 -0700:
> 
> > @@ -1549,7 +1553,7 @@
> >
> >      hwnd = CreateWindowEx(0, gui->classname, "MPlayer", style,
> >                            x, y, rect.right-rect.left,
> > rect.bottom-rect.top,
> > -                          gui->mainwindow, NULL, instance, NULL);
> > +                          NULL, NULL, instance, NULL);
> >
> >      /* set the systray icon properties */
> >      nid.cbSize = sizeof(NOTIFYICONDATA);
> 
> This seems to be unrelated to the console patch.
> 
> I'm not an expert in Windows programming, but it seems to be ok to do so and
> it should be done for the video window, too. Works at least fine with Wine
> (which probably isn't saying much).

It should basically do the same thing as before, since those are
supposed to be NULL there.
I don't really see the point of having a hWnd variable at all though,
or at least not why half the function calls use hWnd and the other half
gui->videowindow when both contain the same value...


More information about the MPlayer-dev-eng mailing list