[MPlayer-dev-eng] [PATCH] add checkmark for menuitem for Debug Console

Ingo Brückl ib at wupperonline.de
Tue Aug 14 20:55:16 CEST 2012


Reimar Döffinger wrote on Tue, 14 Aug 2012 20:04:46 +0200:

> It should basically do the same thing as before, since those are
> supposed to be NULL there.

Using NULL makes the code easier to understand. Like Stephen wrote, it's
counter-intuitive to pass in the handle that we were creating.

> I don't really see the point of having a hWnd variable at all though,
> or at least not why half the function calls use hWnd and the other half
> gui->videowindow when both contain the same value...

Yes, you're right. Another piece of code to be simplified.

Ingo


More information about the MPlayer-dev-eng mailing list