[MPlayer-dev-eng] [PATCH 2/2] demux_avs: unix port using avxsynth

[Reimar Döffinger]

On Fri, Nov 01, 2013 at 06:46:06AM +0100, Gianluigi Tiesi wrote:
> I've made some preliminar tests and it seems to work

I believe the code as it is allows to use Windows-only DLL filters,
does the modified code using dlopen still allow that?

> diff --git a/libmpdemux/demux_avs.h b/libmpdemux/demux_avs.h
> index 7b54657..170e3fe 100644
> --- a/libmpdemux/demux_avs.h
> +++ b/libmpdemux/demux_avs.h
> @@ -1,6 +1,6 @@
>  /*
>   * Demuxer for avisynth
> - * Copyright (c) 2005 Gianluigi Tiesi <sherpya at netfarm.it>
> + * Copyright (c) 2005-2013 Gianluigi Tiesi <sherpya at netfarm.it>

Hm, did you make changes in 2006-2012?
If not, it should be 2005,2013 instead.

> @@ -26,7 +26,6 @@
>  #define MPLAYER_DEMUX_AVS_H
>  
>  #include <stdint.h>
> -#include "loader/wine/windef.h"
>  
>  enum { AVISYNTH_INTERFACE_VERSION = 2 };
>  
> @@ -99,7 +98,7 @@ typedef struct AVS_VideoInfo {
>  
>    int audio_samples_per_second;   // 0 means no audio
>    int sample_type;
> -  uint64_t num_audio_samples;
> +  int64_t num_audio_samples;
>    int nchannels;
>  
>    // Imagetype properties
> @@ -108,7 +107,7 @@ typedef struct AVS_VideoInfo {
>  } AVS_VideoInfo;
>  
>  typedef struct AVS_VideoFrameBuffer {
> -  BYTE * data;
> +  unsigned char * data;
>    int data_size;
>    // sequence_number is incremented every time the buffer is changed, so
>    // that stale views can tell they're no longer valid.

Aren't these changes kind of unrelated?