[MPlayer-dev-eng] [PATCH 2/2] demux_avs: unix port using avxsynth

[Gianluigi Tiesi]

On Sun, Nov 03, 2013 at 10:28:29PM +0100, Reimar Döffinger wrote:
> On Fri, Nov 01, 2013 at 06:46:06AM +0100, Gianluigi Tiesi wrote:
> > I've made some preliminar tests and it seems to work
> 
> I believe the code as it is allows to use Windows-only DLL filters,
> does the modified code using dlopen still allow that?
> 
> Hm, did you make changes in 2006-2012?
> If not, it should be 2005,2013 instead.

lol, typo :)

> 
> > @@ -26,7 +26,6 @@
> >  #define MPLAYER_DEMUX_AVS_H
> >  
> >  #include <stdint.h>
> > -#include "loader/wine/windef.h"
> >  
> >  enum { AVISYNTH_INTERFACE_VERSION = 2 };
> >  
> > @@ -99,7 +98,7 @@ typedef struct AVS_VideoInfo {
> >  
> >    int audio_samples_per_second;   // 0 means no audio
> >    int sample_type;
> > -  uint64_t num_audio_samples;
> > +  int64_t num_audio_samples;
> >    int nchannels;
> >  
> >    // Imagetype properties
> > @@ -108,7 +107,7 @@ typedef struct AVS_VideoInfo {
> >  } AVS_VideoInfo;
> >  
> >  typedef struct AVS_VideoFrameBuffer {
> > -  BYTE * data;
> > +  unsigned char * data;
> >    int data_size;
> >    // sequence_number is incremented every time the buffer is changed, so
> >    // that stale views can tell they're no longer valid.
> 
> Aren't these changes kind of unrelated?

uint64 -> int64 is needed for avxsynth perhaps the C interface
I used the first time was using uint, then one in avisynth
2.5.8 uses int64

BYTE -> unsigned char is needed to eliminate uneeded wine includes

so event they are related "to avxsynth port" commit
I think you can commit the uint64 -> int64 as
"updated avisynth c interface" but you should split also
AVS_T part

I'll post a splitted patch, but you still need to apply
on top of malloc -> calloc patch

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/