[MPlayer-dev-eng] minor build errors

[Reimar Döffinger]

On Tue, Oct 22, 2013 at 09:26:19PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Tue, 22 Oct 2013 21:07:34 +0200:
> 
> > On Tue, Oct 22, 2013 at 07:48:55PM +0200, Ingo Brückl wrote:
> >>  * Forward from area mplayer-user
> >>
> >>  * Originally on: Mon, 21 Oct 2013 03:09:26 -0400
> >>  * Originally by: Robert Henney <robh at rut.org>
> >>  * Originally to: mplayer-users at mplayerhq.hu
> >>  * Original subj: [MPlayer-users] minor build errors
> >>
> >> noticed some shell errors fly by in the build today. (have no idea if they're
> >> new) didn't seem to stop the build from completing though. clipped out
> >> section from output is below. (ie. "/bin/sh: 1: -wN: not found")
> >>
> >> CC      libswscale/utils.o
> >> YASM    libswscale/x86/input.o
> >> STRIP   libswscale/x86/input.o
> >> /bin/sh: 1: -wN: not found
> >> [...]
> >>
> >>  * End of Forward
> >>
> >> Should we define a Makefile variable STRIP? (It's actually rather a FFmpeg
> >> bug though. See the user list there.)
> 
> > $(if $(STRIP), ...), the problem seems to me that this check does not work
> > if STRIP is not defined at all
> 
> Why wouldn't it? Isn't that the purpose of $(if ...)?

I admit I haven't tested it, but then something else must be broken.
The documentation says that "if" only skips the condition code when it
evaluates to an empty string. I kind of assumed that not defined is not
the same as an empty string.
But testing it, you are right.
The reason it doesn't work is the BRIEF/SILENT feature.
As a quick hack, this solves it, but probably the code should be
changed so it handles empty variables an leaves them like that:
--- a/common.mak
+++ b/common.mak
@@ -10,7 +10,7 @@ ifndef SUBDIR
 ifndef V
 Q      = @
 ECHO   = printf "$(1)\t%s\n" $(2)
-BRIEF  = CC CXX HOSTCC HOSTLD AS YASM AR LD STRIP CP
+BRIEF  = CC CXX HOSTCC HOSTLD AS YASM AR LD CP
 SILENT = DEPCC DEPHOSTCC DEPAS DEPYASM RANLIB RM
 
 MSG    = $@