[MPlayer-users] Patches for changing indentation accepted?

[Rogério Brito]

On May 05 2002, Arpi wrote:
> no
> the only case when it's acce[ted, is when the maintainer/author of a
> code part changed indent in his own file.

	Humm, I see. But some files are in a desperate state, needing
	a reindentation and better organization.

	The file that I wanted to change had a function with many
	lines (which makes it hard to understand its purpose). Also,
	it had many long lines, which make using patches a little
	harder than if it had shorter lines. It would be better to
	have them neatly organized.

	And the biggest problem of all was that the indentation was so
	strange that top-level statments of a function had no
	indentation at all.

	I would like to print the code to study it well (perhaps
	documenting it and regarding this as a small-scale "audit" of
	some modules that I understand), but not having indentation
	makes this task take more time. :-(

> > 	1 - how is the development model of mplayer? Since the project
> > 	    is in a pre-release phase, is it currently in a feature
> > 	    freeze? When will further changes be accepted?
> trivial features and bugfixes accepted
> big changes aren't before the release

	Ok, that's good to be conservative regarding big changes.

> > 	2 - are there any coding standards to follow? Are there plans
> > 	    have one, to increase the maintainability and modularity
> > 	    of the project as it grows?
> patches.txt and cvs-howto.txt defines tehse rules

	But that's too little to call coding standards. I was thinking
	along the lines of the Documentation/CodingStyle file of the
	Linux kernel or the GNU coding standards.

> > 	3 - regarding quality assurance (and also connected with
> > 	    question 1), is there any standard test suite used to make
> > 	    sure mplayer works correctly with (at least) a know set of
> > 	    files?
> 
> yes, at ftp.mplayerhq.gy samples/

	Thanks. How frequently is MPlayer run against those files? Are
	there any formalized testing procedure that is used (like in,
	say, 

> > 	I'm asking all this because I already submited one patch for
> > 	corrections of endianness problems in a PowerPC processor and
> > 	I would like to contribute further if it is wanted.
> 
> please avoid indent changes.
> they were never welcomed and were never accepted...

	Well, I can understand your point. A patch that simply changes
	indentation because the person modifying it likes it better
	with another style is indeed something terrible.

	But that doesn't seem to be the case here. :-(


	Thanks for your answer, Roger...

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
  Rogério Brito - rbrito at iname.com - http://www.ime.usp.br/~rbrito/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=