[MPlayer-users] [PATCH] Update Theora support

[David Kuehling]

The Wanderer wrote:

> Bernhard Rosenkraenzer wrote:

>> Hi, mplayer's theora support is still at theora alpha1 level;
>> theora's API changed a bit after that.  The patch I've attached works
>> with current theora CVS (should be compatible with theora alpha2 too,
>> but I haven't tried that).

> When I joined the list, I saw in an archive somewhere a then-recent
> thread - participated in, if I recall correctly, by A'rpi - in which
> someone posted such a fix and received permission to commit it. As of
> now, compiling with Theora enabled fails with CVS sources, in what
> appears at first glance to be the same place as when I moved to CVS to
> begin with. This is annoying, as Theora support was one of the
> significant reasons I made that move.

> Is there any particular reason why this patch not only has not been
> committed, but also has received no response whatsoever?

Don't know.  Arpi complained that the patch makes compilation fail with
his older installation of libtheora.  Of course, as the interface
changed from alpha1 to alpha2.  The correct solution would have either
been to disable Theora support by default (require a configure-option to
explicitely enable it) or to improve auto-detection to check for the
existence and functionality of all interface-routines used by mplayer.

I wanted to improve my patch and repost it but got so extremely busy
with university that I didn't got to it.  Hoped they would commit the
patch anyway and do the required change to configure themselves.  Didn't
check CVS for some weeks.  At least my patched version of mplayer works
:-).

Unless someone else wants to take over as maintainer for theora-support,
I'll get the thing fixed tomorrow and upload a new sample by the end of
the week.

David
-- 
GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg
Fingerprint: B17A DC95 D293 657B 4205  D016 7DEF 5323 C174 7D40