[MPlayer-users] [PATCH] ./configure syntax error

[Steven M. Schultz]

Hi -

> From: D Richard Felker III <dalias at aerifal.cx>
> >       The proper way to fix ./configure is to use "test" rather than exchange
> >       one syntax error for another.   Sigh ;(
> > 
> > --- configure.dist    Tue Dec 31 14:01:41 2002
> > +++ configure Tue Dec 31 14:01:59 2002
> > @@ -5400,7 +5400,7 @@
> >  EOF
> >  fi
> >  
> > -if x86 && ! cygwin; then
> > +if test x86 -a ! cygwin; then
> 
> I don't think so. x86 and cygwin are function calls, not variables.

	Right.  And the shell will evaluate them as function calls _before_
	invoking 'test' - won't it?

	So 'x86' gets run and returns 0 or 1, 'cygwin' runs and returns
	0 or 1 and then (finally) 'test' gets run and does the comparisons.

	I really think it's a bash != sh  issue.   If the top line of the
	./configure script is changed from '#!/bin/sh' to '#!/bin/bash'
	then I do not get the syntax error at line 5403.

	Cheers!
	Steven Schultz
	sms at 2bsd.com