[MPlayer-users] Cannot compile: `CONFIG_X86_L1_CACHE_SHIFT' undeclared

[D Richard Felker III]

On Fri, Nov 26, 2004 at 12:34:03PM -0500, D Richard Felker III wrote:
> On Thu, Nov 25, 2004 at 06:57:26PM +0100, Sascha Sommer wrote:
> > > regardless of all the stuff i'll say about linux being broken, the
> > > stuff in mplayer is horribly broken too. here is the contents of
> > > osdep/kerneltwosix.h:
> > >
> > > ----------------------------------------------------------------------
> > > #include <linux/version.h>
> > > #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,70)
> > > #define __KERNEL__
> > > #include <linux/thread_info.h>
> > > #include <linux/list.h>
> > > #undef __KERNEL__
> > > #endif
> > > ----------------------------------------------------------------------
> > >
> > > as you can see, it #defines __KERNEL__ which is only supposed to be
> > > done for KERNEL-INTERNAL CODE! it also includes headers that are
> > > seemingly irrelevant. i have no rational explanation for why crap like
> > > this should be included in vo_fbdev... :(
> > >
> > 
> > MPlayer still compiles/works fine for me without it on 2.6.9
> > and on a SuSE 9.1 box I tested it on. Therefore I vote for removing it asap.
> 
> afaik this code was added as a bug workaround for an old version of
> linux 2.6.x that failed to define the right structs unless __KERNEL__
> was defined. i vote for removing it too, but read cvslog to check
> first.

it's been removed. all compile problems should be gone now.

rich