[MPlayer-users] ao-alsa noise...

[gabor]

On Sat, 2004-06-12 at 09:31 +0800, ephemeron at softhome.net wrote:
> On 10. June 2004 at 11:19PM +0200,
> gabor <gabor at z10n.net> wrote:
> 
> > On Thu, 2004-06-10 at 18:52 +0800, ephemeron at softhome.net wrote:
> > > On 10. June 2004 at 12:18AM +0200,
> > > gabor <gabor at z10n.net> wrote:
> > >
> > > > i have an acer800laptop...it has an intel sound chip (users
> > > > the snd-intel8x0 alsa module).  but now, with the unified
> > > > 'alsa' driver, i sometimes get noises into the video
> > > > playback...
> > 
> > > Somebody posted a patch a few days ago.  Basically it changes the
> > > following unique line in {MPLAYER-SOURCE-ROOT}/libao2/ao_alsa.c:
> > > 
> > > #undef SET_CHUNKSIZE
> > > 
> > > to
> > > 
> > > #define SET_CHUNKSIZE
> > > 
> > > Try "grep 'def.*SET_CHUNKSIZE' ./libao2/ao_alsa*" to compare
> > > the differences between the alsa9, alsa1x and unified alsa
> > > output drivers. "#define SET_CHUNKSIZE" is in alsa1x.
> > 
> > wow...it fixes my problem...
> > 
> > the line
> > alsa: 48000 Hz/2 channels/4 bpf/32768 bytes buffer/Signed 16 bit Little
> > Endian
> > 
> > changed into:
> > alsa: 48000 Hz/2 channels/4 bpf/65536 bytes buffer/Signed 16 bit Little
> > Endian
> > and was the patch considered to be included? was it rejected?
> 
> I don't think so. I did a CVS checkout today, and noticed that
> there was an update to libao2/ao_alsa.c, but the line still reads
> "#undef SET_CHUNKSIZE".
> 
> I beginning to suspect this problem affects only onboard sound
> chips or some developer would have noticed it by now.

well, i can post a mail with a subject "[PATCH] fix my alsa problem" to
mplayer-dev-eng....

question.. can u try it? does it break anything for you?
or more generally: are you against this fix?
gabor