[MPlayer-users] iconv configure check bug?

[Mark Himsley]

$ uname -a
Darwin macmini2 9.6.0 Darwin Kernel Version 9.6.0: Mon Nov 24 17:37:00
PST 2008; root:xnu-1228.9.59~1/RELEASE_I386 i386

I just did a svn up; make distclean; ./configure; make.

The final cc -o mplayer ... failed with:

Undefined symbols:
  "_iconv_close", referenced from:
      _mp_msg in mp_msg.o
      _subcp_close in subreader.o
      _sub_read_file in subreader.o
      _sub_read_file in subreader.o
      _sub_read_file in subreader.o
      _prepare_charset in font_load_ft.o
      _prepare_charset in font_load_ft.o
      _sub_recode in ass.o
  "_iconv", referenced from:
      _filename_recode in mp_msg.o
      _mp_msg in mp_msg.o
      _subcp_recode in subreader.o
      _subcp_recode in subreader.o
      _prepare_charset in font_load_ft.o
      _sub_recode in ass.o
      _sub_recode in ass.o
  "_iconv_open", referenced from:
      _filename_recode in mp_msg.o
      _mp_msg in mp_msg.o
      _subcp_open in subreader.o
      _sub_read_file in subreader.o
      _prepare_charset in font_load_ft.o
      _prepare_charset in font_load_ft.o
      _sub_recode in ass.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [mplayer] Error 1


Looking in configure.log I see this:

##########################################

============ Checking for iconv ============

<SNIP1>

cc -Wundef -Wdisabled-optimization -Wno-pointer-sign
-Wdeclaration-after-statement -std=gnu99 -Wall -Wn
o-switch -Wpointer-arith -Wredundant-decls -O4 -march=pentium-m
-mtune=pentium-m -pipe -ffast-math -fom
it-frame-pointer -mdynamic-no-pic -falign-loops=16 -shared-libgcc -I.
  -ffast-math    -o /var/folder
s/Vy/Vyp6fg5mG+eWB0QHWXHbwU+++TI/-Tmp-//mplayer-conf-5594-63434
/var/folders/Vy/Vyp6fg5mG+eWB0QHWXHbwU+
++TI/-Tmp-//mplayer-conf-1184-63434.c -lm
/var/folders/Vy/Vyp6fg5mG+eWB0QHWXHbwU+++TI/-Tmp-//mplayer-conf-1184-63434.c:
In function 'main':
/var/folders/Vy/Vyp6fg5mG+eWB0QHWXHbwU+++TI/-Tmp-//mplayer-conf-1184-63434.c:21:
warning: passing argum
ent 2 of 'iconv' from incompatible pointer type
Undefined symbols:
  "_iconv", referenced from:
      _main in ccW5PceX.o
  "_iconv_close", referenced from:
      _main in ccW5PceX.o
  "_iconv_open", referenced from:
      _main in ccW5PceX.o
ld: symbol(s) not found
collect2: ld returned 1 exit status


<SNIP2>

cc -Wundef -Wdisabled-optimization -Wno-pointer-sign
-Wdeclaration-after-statement -std=gnu99 -Wall -Wn
o-switch -Wpointer-arith -Wredundant-decls -O4 -march=pentium-m
-mtune=pentium-m -pipe -ffast-math -fom
it-frame-pointer -mdynamic-no-pic -falign-loops=16 -shared-libgcc -I.
  -ffast-math    -o /var/folder
s/Vy/Vyp6fg5mG+eWB0QHWXHbwU+++TI/-Tmp-//mplayer-conf-5594-63434
/var/folders/Vy/Vyp6fg5mG+eWB0QHWXHbwU+
++TI/-Tmp-//mplayer-conf-1184-63434.c -lm -liconv
/var/folders/Vy/Vyp6fg5mG+eWB0QHWXHbwU+++TI/-Tmp-//mplayer-conf-1184-63434.c:
In function 'main':
/var/folders/Vy/Vyp6fg5mG+eWB0QHWXHbwU+++TI/-Tmp-//mplayer-conf-1184-63434.c:21:
warning: passing argum
ent 2 of 'iconv' from incompatible pointer type


Result is: yes
##########################################

Result yes? I'm not convinced configure has got that right!


./configure --disable-iconv compiles correctly.

So my question is, is it me of is it a bug in configure?

Thanks.

-- 
Mark