[Ffmpeg-devel-irc] ffmpeg-devel.log.20150822

burek burek021 at gmail.com
Sun Aug 23 02:05:03 CEST 2015

[00:25:41 CEST] <ubitux> i'm not on my main computer; does anyone mind applying http://b.pkh.me/0001-avcodec-version-fix-2-recently-introduced-typo.patch ?
[00:25:48 CEST] <ubitux> otherwise i'll do it in the next 24h
[00:34:33 CEST] <cone-525> ffmpeg 03Clément BSsch 07master:cafba99b5146: avcodec/version: fix 2 recently introduced typo
[00:34:38 CEST] <jamrial> ubitux: ^
[00:34:46 CEST] <ubitux> jamrial: thx :)
[00:34:55 CEST] <jamrial> np
[00:37:18 CEST] <cone-525> ffmpeg 03Rostislav Pehlivanov 07master:670dfda143fc: aacenc_tns: remove unused header
[00:37:37 CEST] <atomnuker> thanks @nevcairiel
[03:08:10 CEST] <cone-525> ffmpeg 03Ganesh Ajjanagadde 07master:531b0a316b24: avutil/x86/asm: rename REG_SP to REG_sp
[03:23:14 CEST] <Timothy_Gu> atomnuker: next time you submit patches that add symbols visible across the entire library, don't forget to add ff_ prefixes
[03:24:40 CEST] <Timothy_Gu> atomnuker: see https://ffmpeg.org/pipermail/ffmpeg-devel/2015-August/177627.html for what I meant
[03:25:04 CEST] <Timothy_Gu> and https://www.ffmpeg.org/developer.html#Naming-conventions says "For variables and functions visible outside of file scope, but only used internally by a library, an `ff_` prefix should be used, e.g. ff_w64_demuxer."
[05:15:36 CEST] <cone-525> ffmpeg 03Timothy Gu 07master:5cbcf2b24d28: aacenctab: Use FF_ARRAY_ELEMS
[05:33:13 CEST] <cone-525> ffmpeg 03Timothy Gu 07master:15ebc7787c6c: aacenctab: Add missing ff_ prefixes
[05:58:39 CEST] <cone-525> ffmpeg 03Timothy Gu 07master:d4401a9e0d66: aacenc: Harmonize multiple inclusion guards
[07:12:49 CEST] <cone-525> ffmpeg 03Timothy Gu 07master:21dd5279c3c4: aacenc: Add missing ff_ prefixes
[07:17:06 CEST] <Timothy_Gu> atomnuker: a struct isn't considered to be a "symbol" and "ff_" therefore is not usually prepended
[07:17:24 CEST] <Timothy_Gu> Also for structures we usually use CamelCase.
[07:20:54 CEST] <cone-525> ffmpeg 03Timothy Gu 07master:e8279880dcf7: acenctab: Fix merge conflict
[07:24:39 CEST] <atomnuker> the struct's fine, don't worry about it
[07:24:54 CEST] <atomnuker> I have a dislike for camelcase
[07:36:09 CEST] <Timothy_Gu> atomnuker: you are a gsoc student right?
[07:39:30 CEST] <atomnuker> yes
[07:39:34 CEST] <atomnuker> *was
[07:41:51 CEST] <Timothy_Gu> ah
[07:48:37 CEST] <cone-525> ffmpeg 03Rostislav Pehlivanov 07master:2c94e45fadf4: aacenc_is: rename struct to follow guidelines
[07:49:17 CEST] <atomnuker> yeah, on second though ff_aac_is_error was kinda less fitting
[08:00:05 CEST] <Timothy_Gu> atomnuker: looks much better. thanks!
[09:13:51 CEST] <cone-525> ffmpeg 03Rostislav Pehlivanov 07master:ae1b9c975409: fate: added PNS, TNS and IS tests for the AAC encoder
[09:53:37 CEST] <cone-525> ffmpeg 03Rostislav Pehlivanov 07master:7adb6d5aab33: aacenc_quantization: replace copysign() with a ternary operator
[10:16:52 CEST] <nevcairiel> atomnuker: the fun isnt stopping, found another one from msvc :D aacenc_quantization.h(113) : error C4013: 'copysignf' undefined; assuming extern returning int
[10:17:16 CEST] <atomnuker> I beg to differ
[10:17:38 CEST] <atomnuker> look at the very last commin, hash 7adb6d5aab33
[10:18:00 CEST] <atomnuker> *commit
[10:18:03 CEST] <nevcairiel> ah
[10:18:11 CEST] <nevcairiel> i didnt pay attention to the timestamp
[10:18:18 CEST] <nevcairiel> figured a build 20 minutes ago would surely be up to date
[10:20:15 CEST] <atomnuker> didn't know we had SuperH FATE machines
[13:04:53 CEST] <nevcairiel> well my fate systems are happy again, thanks for fixing all the problems ;)
[17:07:07 CEST] <Timothy_Gu> nevcairiel, atomnuker: made you guys ops because you maintain part of FFmpeg
[17:09:37 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:0aa9bbbc377a: version: Fix two more typos
[17:34:48 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:8d9fe002b335: fmtconvert: Remove float_interleave*
[17:39:18 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:1597dba86ae7: aacdec_fixed: Make exp2tab static const
[17:39:19 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:e10ef3289d70: aacsbr_fixed: Make fixed_{exp,log}_table static const
[17:39:20 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:ee4cc806537d: vp9dsp: Add missing ff_ prefixes
[17:39:21 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:f0af25ae119d: ffv1: Add missing ff_ prefixes
[17:47:45 CEST] <nevcairiel> Timothy_Gu: but all the ffv1 functions already start with ff :D
[17:48:43 CEST] <wm4> but not ff_, apparently
[17:49:38 CEST] <nevcairiel> dont ruin my trolling :(
[17:58:59 CEST] <Timothy_Gu> :)
[18:05:12 CEST] <jamrial> atomnuker: not sure if you noticed but one and in some cases both aac tests are failing on several fate clients
[18:06:27 CEST] <nevcairiel> looks like rounding differences
[18:07:05 CEST] <nevcairiel> although it segfauled on a few linux boxes
[18:08:11 CEST] <nevcairiel> i wish it would record the cpu info in the fate thingy
[18:16:43 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:5dee7a32d738: git-howto: Various copy edits
[18:45:28 CEST] <atomnuker> jamarial: yeah, noticed this before I went to sleep, might be happening because of the bitshifting business
[19:09:02 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:c5d9e9b354a3: doxygen: Remove lavu_internal group
[19:15:29 CEST] <cone-529> ffmpeg 03Timothy Gu 07master:5f1c37aefbdc: avcodec: Fix `make checkheaders`
[19:16:28 CEST] <cone-529> ffmpeg 03Andreas Cadhalpun 07master:c363843a5355: add missing FF_API_DESTRUCT_PACKET guards
[19:16:29 CEST] <cone-529> ffmpeg 03Andreas Cadhalpun 07master:9acf5341d6a6: openal-dec: replace av_destruct_packet with av_free_packet
[19:16:30 CEST] <cone-529> ffmpeg 03Andreas Cadhalpun 07master:805f38b4d618: fate: replace deprecated request_channels with request_channel_layout
[19:16:31 CEST] <cone-529> ffmpeg 03Andreas Cadhalpun 07master:095347ffe4c7: disable deprecation warnings in deprecated code
[19:53:04 CEST] <wm4> sometimes I get the feeling there should be a libavpriv
[19:53:24 CEST] <BBB> dont suggest silly things
[19:53:27 CEST] <BBB> people may actually do it
[19:53:31 CEST] <BBB> remember libavcore?
[19:53:33 CEST] <wm4> D:
[19:53:49 CEST] <wm4> but seriously, the lib separation is just a joke
[19:53:56 CEST] <BBB> it is
[19:54:40 CEST] <BtbN> Well, wouldn't stop people from linking with it.
[19:55:32 CEST] <BtbN> Unless it gets some magic that deliberately mangles the symbol names each time it's built.
[19:58:46 CEST] <Timothy_Gu> maybe i should send the av_ctz patch to libav&
[20:06:55 CEST] <cone-529> ffmpeg 03Paul B Mahol 07master:e95193f5eaf1: avfilter/vf_vectorscope: add more pixel formats
[22:04:20 CEST] <cone-529> ffmpeg 03Paul B Mahol 07master:14f97bb2bc32: avfilter: add waveform monitor filter
[22:15:27 CEST] <cone-529> ffmpeg 03Ganesh Ajjanagadde 07master:eb3cfa7dd323: swscale/alphablend: fix pointer cast
[00:00:00 CEST] --- Sun Aug 23 2015

More information about the Ffmpeg-devel-irc mailing list